Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: remove unused variable from try catch #23452

Closed
wants to merge 1 commit into from
Closed

repl: remove unused variable from try catch #23452

wants to merge 1 commit into from

Conversation

mmisiarek
Copy link
Contributor

Catch statement defines err variable that is never used, so it
is safe to remove that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Oct 12, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@mmisiarek
repl: remove unused variable from try catch
a824bb9 
Catch statement defines err variable that is never used, so it
is safe to remove that.
@mmisiarek mmisiarek force-pushed the repl-await-unused-var branch from 3f44e8e to a824bb9 Compare October 12, 2018 18:41
@mmisiarek mmisiarek changed the title repl: remove unused variable from try catch. repl: remove unused variable from try catch Oct 12, 2018
@Trott
Copy link
Member

Trott commented Oct 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17800

@Trott
Copy link
Member

Trott commented Oct 13, 2018

Collaborators, please 👍 here to approve fast-tracking.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 13, 2018
@Trott
Copy link
Member

Trott commented Oct 13, 2018

Landed in c301518.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Oct 13, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 13, 2018
@mmisiarek @Trott
repl: remove unused variable from try catch
c301518 
Catch statement defines err variable that is never used, so it
is safe to remove that.

PR-URL: nodejs#23452
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@mmisiarek @addaleax
repl: remove unused variable from try catch
1ee3abb 
Catch statement defines err variable that is never used, so it
is safe to remove that.

PR-URL: #23452
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@mmisiarek @jasnell
repl: remove unused variable from try catch
6855b61 
Catch statement defines err variable that is never used, so it
is safe to remove that.

PR-URL: #23452
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@mmisiarek @MylesBorins
repl: remove unused variable from try catch
9dfc13e 
Catch statement defines err variable that is never used, so it
is safe to remove that.

PR-URL: #23452
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@mmisiarek @rvagg
repl: remove unused variable from try catch
9d6528d 
Catch statement defines err variable that is never used, so it
is safe to remove that.

PR-URL: #23452
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@mmisiarek @MylesBorins
repl: remove unused variable from try catch
d07ee1c 
Catch statement defines err variable that is never used, so it
is safe to remove that.

PR-URL: #23452
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mmisiarek @Trott @jasnell @thefourtheye @cjihrig @gireeshpunathil @nodejs-github-bot