Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix bug in MallocedBuffer #23434

Closed
wants to merge 1 commit into from
Closed

src: fix bug in MallocedBuffer #23434

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

This should be a generic type even though we are currently only using char as T.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@tniessen tniessen requested a review from addaleax October 12, 2018 00:05
@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1209/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 12, 2018
thefourtheye
thefourtheye approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message has a typo and its very generic.

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17745/

Please 👍 this comment to approve fast-tracking.

@addaleax addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 12, 2018
@addaleax
Copy link
Member

Landed in 714c1b8

@addaleax addaleax closed this Oct 12, 2018
addaleax pushed a commit that referenced this pull request Oct 12, 2018
@tniessen @addaleax
src: fix bug in MallocedBuffer constructor
714c1b8 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott pushed a commit that referenced this pull request Oct 13, 2018
@tniessen @Trott
src: fix bug in MallocedBuffer constructor
2218a38 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 13, 2018
@tniessen @targos
src: fix bug in MallocedBuffer constructor
678019c 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack refack mentioned this pull request Oct 13, 2018
Closed
2 tasks
@refack refack mentioned this pull request Oct 13, 2018
Closed
2 tasks
refack added a commit to refack/node that referenced this pull request Oct 13, 2018
@refack
src: refacor MallocedBuffer to it's usage scope
d16f098 
Ref: nodejs#23543 (review)
Ref: nodejs#23434
@refack refack mentioned this pull request Oct 13, 2018
Closed
3 tasks
refack added a commit to refack/node that referenced this pull request Oct 13, 2018
@refack
src: malloced_unique_ptr & make_malloced_unique
bca838b 
Ref: nodejs#23641
Ref: nodejs#23543 (review)
Ref: nodejs#23434
@refack refack mentioned this pull request Oct 13, 2018
Closed
3 tasks
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@tniessen @jasnell
src: fix bug in MallocedBuffer constructor
ecacf33 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
refack added a commit to refack/node that referenced this pull request Oct 20, 2018
@refack
src: malloced_unique_ptr & make_malloced_unique
5bd49eb 
Ref: nodejs#23641
Ref: nodejs#23543 (review)
Ref: nodejs#23434
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@tniessen @MylesBorins
src: fix bug in MallocedBuffer constructor
8cd41aa 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@tniessen @rvagg
src: fix bug in MallocedBuffer constructor
0d3364d 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@tniessen @MylesBorins
src: fix bug in MallocedBuffer constructor
a663d56 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @addaleax @refack @jasnell @thefourtheye @gireeshpunathil