-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: make Travis commit linting more robust #23397
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some situations. Refs: nodejs#23307 (comment)
addaleax
approved these changes
Oct 10, 2018
Trott
added
fast-track
PRs that do not need to wait for 48 hours to land.
and removed
wip
Issues and PRs that are still a work in progress.
labels
Oct 10, 2018
Looks ready-to-go. Light CI should be sufficient. 👍 here to fast-track. |
3 tasks
danbev
approved these changes
Oct 10, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 10, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some situations. Refs: nodejs#23307 (comment) PR-URL: nodejs#23397 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Landed in a1edecc |
This was referenced Oct 10, 2018
targos
pushed a commit
that referenced
this pull request
Oct 10, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some situations. Refs: #23307 (comment) PR-URL: #23397 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
This was referenced Oct 10, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some situations. Refs: #23307 (comment) PR-URL: #23397 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some situations. Refs: #23307 (comment) PR-URL: #23397 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some situations. Refs: #23307 (comment) PR-URL: #23397 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.
Refs: #23307 (comment)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes