add WPT Console tests #23340

Trott · 2018-10-08T20:39:22Z

First commit:

test: rename WPT console test

test-console-is-a-namespace.js is a WPT Console test. It is the only
WPT Console test file that we have that doesn't start with
`test-whatwg-`. Rename it to test-whatwg-console-is-a-namespace.any.js
so that WPT tests can be found relatively easily. Just as it is useful
to separate the WPT URL tests from our URL tests, it will likely be
useful to separate our Console tests from WPT Console tests if we add
more WPT Console tests (which I hope we do).

Second commit:

test: add WPT console-label-conversion test

Add console-label-conversion.any.js from WPT to the test suite.

Third commit:

test: separate WPT console test from other test

Remove one test from test-whatwg-console-is-a-namespace that is not part
of the WPT test. Put it in test-console-self-assign.

Fourth commit:

test: add WPT console-tests-historical

Add WPT console-tests-historical to the test suite.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot · 2018-10-08T20:39:24Z

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1170/pipeline

Trott · 2018-10-08T20:46:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17688/ ✔️

Trott · 2018-10-09T03:27:49Z

/ping @nodejs/testing This needs some reviews.

test/parallel/test-whatwg-console-tests-historical.js

test/parallel/test-whatwg-console-label-conversion.js

richardlau

First commit message says:
Rename it to test-whatwg-console-is-a-namespace.any.js
The .any should be removed (it doesn't look like the Node.js equivalents of the WPT tests keep the .any part of the filename).

test-console-is-a-namespace.js is a WPT Console test. It is the only WPT Console test file that we have that doesn't start with `test-whatwg-`. Rename it to test-whatwg-console-is-a-namespace.js so that WPT tests can be found relatively easily. Just as it is useful to separate the WPT URL tests from our URL tests, it will likely be useful to separate our Console tests from WPT Console tests if we add more WPT Console tests (which I hope we do).

Add console-label-conversion.any.js from WPT to the test suite.

Remove one test from test-whatwg-console-is-a-namespace that is not part of the WPT test. Put it in test-console-self-assign.

Add WPT console-tests-historical to the test suite.

Trott · 2018-10-09T04:45:26Z

Fixed .any in commit message, rebased, force-pushed.

CI: https://ci.nodejs.org/job/node-test-pull-request/17698/ ✔️

test-console-is-a-namespace.js is a WPT Console test. It is the only WPT Console test file that we have that doesn't start with `test-whatwg-`. Rename it to test-whatwg-console-is-a-namespace.js so that WPT tests can be found relatively easily. Just as it is useful to separate the WPT URL tests from our URL tests, it will likely be useful to separate our Console tests from WPT Console tests if we add more WPT Console tests (which I hope we do). PR-URL: nodejs#23340 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Add console-label-conversion.any.js from WPT to the test suite. PR-URL: nodejs#23340 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Remove one test from test-whatwg-console-is-a-namespace that is not part of the WPT test. Put it in test-console-self-assign. PR-URL: nodejs#23340 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Add WPT console-tests-historical to the test suite. PR-URL: nodejs#23340 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Trott · 2018-10-10T22:08:34Z

Landed in cd8ee2d...6330830

test-console-is-a-namespace.js is a WPT Console test. It is the only WPT Console test file that we have that doesn't start with `test-whatwg-`. Rename it to test-whatwg-console-is-a-namespace.js so that WPT tests can be found relatively easily. Just as it is useful to separate the WPT URL tests from our URL tests, it will likely be useful to separate our Console tests from WPT Console tests if we add more WPT Console tests (which I hope we do). PR-URL: #23340 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>