doc: add WebAssembly to globals #23339
Conversation
|
Possibly unrelated to this PR, but it seems like there's some room for cleanup? |
|
@Trott Thanks for the quick review! Do you know why I'm getting this lint error? "blank line expected after title" |
|
The Travis linter error about the commit message needing a blank line after the title can be ignored. It's a known issue with core-validate-commit that will be fixed when we publish a new release of core-validate-commit. Ref: nodejs/core-validate-commit#29 I'll ping the people with publishing ability. |
|
Can we really name it as Class considering this note?
|
|
@vsemozhetbyt Good point, I removed the "Class" prefix. Eventually, it could probably be removed from |
|
Thanks all! Anything else I need to do (should I fix the commit message)? |
Nothing else to do. This needs to stay open another 19 hours or else be fast-tracked, but I don't think we need it to be fast-tracked unless we're trying to get it into the 10.12.0 release? Which actually might not be a bad idea. Collaborators, 👍 here to fast-track. |
|
Landed in 487020e |
PR-URL: nodejs#23339 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23339 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23339 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23339 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23339 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23339 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes #23334
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes