crypto: make PEM parsing RFC7468-compliant #23164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Oct 1, 2018
src/node_crypto.cc
Outdated
| static ParsePublicKeyResult TryParsePublicKey( | ||
| EVPKeyPointer* pkey, | ||
| const BIOPointer& bp, | ||
| char* name, |
There was a problem hiding this comment.
Can be const char* name, right?
|
CI: https://ci.nodejs.org/job/node-test-pull-request/17561/ cc @nodejs/crypto |
jasnell
approved these changes
Oct 1, 2018
tniessen
added
the
author ready
|
Landed in ad07e44, thanks for reviewing. |
tniessen
added a commit
that referenced
this pull request
Oct 2, 2018
PR-URL: #23164 Fixes: #13612 Fixes: #22815 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #23164 Fixes: #13612 Fixes: #22815 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 10, 2018
tniessen
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses
PEM_bytes_read_bioas suggested by @bnoordhuis to parse public keys as described in RFC7468.Fixes: #13612
Fixes: #22815
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes