test: fix tick-processor tests and run them in CI

test/common/tick-processor.js

@@ -0,0 +1,118 @@
+'use strict';
+
+const {
+  isWindows,
+  isSunOS,
+  isAIX,
+  isLinuxPPCBE,
+  isFreeBSD,
+  skip
+} = require('../common');
+
+const fs = require('fs');
+const cp = require('child_process');
+const path = require('path');
+
+const tmpdir = require('./tmpdir');
+tmpdir.refresh();
+
+const LOG_FILE = path.join(tmpdir.path, 'tick-processor.log');
+const START_PROF_PROCESS_TIMEOUT = 400;
+
+let running = 0;
+let ran = 0;
+
+// The tick processor is not supported on all platforms.
+function isCPPSymbolsNotMapped() {
+  if (isWindows || isSunOS || isAIX || isLinuxPPCBE || isFreeBSD) {
+    skip('C++ symbols are not mapped for this OS.');
+    return true;
+  }
+  return false;
+}
+
+function runTest(test) {
+  if (isCPPSymbolsNotMapped()) {
+    return;
+  }
+
+  ran++;
+  running = 0;
+  const proc = cp.spawn(process.execPath, [
+    '--no_logfile_per_isolate',
+    '--logfile=-',
+    '--prof',
+    '-pe', test.code
+  ], {
+    stdio: [ 'ignore', 'pipe', 'inherit' ]
+  });
+
+  let ticks = '';
+  proc.stdout.on('data', (chunk) => ticks += chunk);
+
+  // Check if the pattern is already there or not.
+  setTimeout(() => {
+    if (running === 0) {
+      match(test, proc, () => ticks);
+    }
+  }, START_PROF_PROCESS_TIMEOUT);
+
+  proc.on('exit', () => {
+    running++;
+    if (running === 1) {
+      match(test, proc, () => ticks);
+    }
+  });
+}
+
+function match(test, parent, ticks) {
+  running++;
+
+  const { pattern, profProcessFlags: flags = [] } = test;
+  // Store current ticks log
+  fs.writeFileSync(LOG_FILE, ticks());
+
+  const proc = cp.spawn(process.execPath, [
+    '--prof-process',
+    '--call-graph-size=10',
+    ...flags,
+    LOG_FILE
+  ], {
+    stdio: [ 'ignore', 'pipe', 'inherit' ]
+  });
+
+  let out = '';
+
+  proc.stdout.on('data', (chunk) => out += chunk);
+  proc.stdout.once('end', () => {
+    proc.once('exit', () => {
+      fs.unlinkSync(LOG_FILE);
+
+      // Retry after timeout
+      if (!pattern.test(out)) {
+        running--;
+        // If the profiling is done without match, try up to ten times again
+        // and then fail.
+        if (running === 1) {
+          if (ran < 10) {
+            return runTest(test);
+          }
+          console.error(out);
+          throw new Error(`${pattern} Failed`);
+        }
+        return;
+      }
+
+      parent.stdout.removeAllListeners();
+      parent.kill();
+    });
+
+    proc.stdout.removeAllListeners();
+    proc.kill();
+  });
+}
+
+module.exports = {
+  runTest,
+  isCPPSymbolsNotMapped
+};

test/sequential/test-tick-processor-builtin.js

@@ -0,0 +1,20 @@
+'use strict';
+require('../common');
+
+const base = require('../common/tick-processor');
+
+base.runTest({
+  // If the C++ symbols are not detected by the OS, no JS is going to be
+  // executed.
+  pattern: /Builtin: ObjectKeys| \d    [0-6]\.\d%    [0-6]\.\d%  JavaScript/,
+  code: `let add = 0;
+         const obj = { a: 5 };
+         function f() {
+           for (var i = 0; i < 4e6; i++) {
+             obj.a = i;
+             add += Object.keys(obj).length;
+           }
+           return add;
+         };
+         f();`
+});

test/sequential/test-tick-processor-cpp-core.js

@@ -0,0 +1,16 @@
+'use strict';
+require('../common');
+
+const base = require('../common/tick-processor');
+
+base.runTest({
+  // If the C++ symbols are not mapped to the OS they can end up as `UNKNOWN` or
+  // no JS is executed at all.
+  pattern: /MakeContext|\d\d\.\d%  UNKNOWN|0    0\.0%    0\.0%  JavaScript|[7-9]\d\.\d%   [7-9]\d\.\d%  write/,
+  code: `function f() {
+           for (var i = 0; i < 5e2; i++) {
+             require('vm').createContext({});
+           }
+         };
+         f();`
+});

test/tick-processor/test-tick-processor-polyfill-brokenfile.js → test/sequential/test-tick-processor-polyfill-brokenfile.js

@@ -1,37 +1,39 @@
 'use strict';
-const common = require('../common');
-const { isCPPSymbolsNotMapped } = require('./util');
-const tmpdir = require('../common/tmpdir');
-tmpdir.refresh();
+const { skip } = require('../common');
 
-if (!common.enoughTestCpu)
-  common.skip('test is CPU-intensive');
+const { isCPPSymbolsNotMapped } = require('../common/tick-processor');
 
 if (isCPPSymbolsNotMapped) {
-  common.skip('C++ symbols are not mapped for this OS.');
+  skip('C++ symbols are not mapped for this OS.');
 }
 
+const tmpdir = require('../common/tmpdir');
+tmpdir.refresh();
+
 // This test will produce a broken profile log.
 // ensure prof-polyfill not stuck in infinite loop
 // and success process
 
-
 const assert = require('assert');
 const { spawn, spawnSync } = require('child_process');
 const path = require('path');
 const { writeFileSync } = require('fs');
 
 const LOG_FILE = path.join(tmpdir.path, 'tick-processor.log');
-const RETRY_TIMEOUT = 150;
+const RETRY_TIMEOUT = 250;
 const BROKEN_PART = 'tick,';
 const WARN_REG_EXP = /\(node:\d+\) \[BROKEN_PROFILE_FILE] Warning: Profile file .* is broken/;
 const WARN_DETAIL_REG_EXP = /".*tick," at the file end is broken/;
 
-const code = `function f() {
-           this.ts = Date.now();
-           setImmediate(function() { new f(); });
-         };
-         f();`;
+const code = `
+  let add = 0;
+  function f() {
+    for (var i = 0; i < 1e3; i++) {
+      add += Date.now();
+    }
+    return add;
+  };
+  f();`;
 
 const proc = spawn(process.execPath, [
   '--no_logfile_per_isolate',
@@ -45,7 +47,6 @@ const proc = spawn(process.execPath, [
 let ticks = '';
 proc.stdout.on('data', (chunk) => ticks += chunk);
 
-
 function runPolyfill(content) {
   proc.kill();
   content += BROKEN_PART;

test/sequential/test-tick-processor-preprocess-flag.js

@@ -0,0 +1,15 @@
+'use strict';
+require('../common');
+
+const base = require('../common/tick-processor');
+
+base.runTest({
+  pattern: /^{/,
+  code: `function f() {
+          for (var i = 0; i < 5e2; i++) {
+            require('vm').createContext({});
+          }
+         };
+         f();`,
+  profProcessFlags: ['--preprocess']
+});