Revert "src: implement query callbacks for vm" #22911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 85c356c from PR nodejs#22390. See the discussion in the (proposed) fix at nodejs#22836. Refs: nodejs#22836 Refs: nodejs#22390 Fixes: nodejs#22723
nodejs-github-bot
added
c++
|
CI: https://ci.nodejs.org/job/node-test-pull-request/17254/ Please 👍 this comment to approve fast-tracking. |
cjihrig
approved these changes
Sep 17, 2018
devsnek
approved these changes
Sep 17, 2018
TimothyGu
approved these changes
Sep 17, 2018
jdalton
approved these changes
Sep 17, 2018
|
Linux re-build: https://ci.nodejs.org/job/node-test-commit-linux/21644/ |
addaleax
added
the
author ready
|
Windows re-build has (unrelated) failures, again: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20818/ |
BridgeAR
approved these changes
Sep 18, 2018
|
Landed in 8989c76 |
addaleax
added a commit
that referenced
this pull request
Sep 18, 2018
This reverts commit 85c356c from PR #22390. See the discussion in the (proposed) fix at #22836. Refs: #22836 Refs: #22390 Fixes: #22723 PR-URL: #22911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 85c356c from PR #22390.
See the discussion in the (proposed) fix at #22836.
Fixes: #22723
I’ll update the fix PR with a revert of the revert as soon as this lands, so that we have an open PR where we can iron out the remaining issues here.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes