Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add apapirovski to TSC #22717

Closed
wants to merge 1 commit into from
Closed

doc: add apapirovski to TSC #22717

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 5, 2018

@nodejs/tsc Please 👍 here to fast-track.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 5, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/806/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 5, 2018
@Trott Trott changed the title doc: add apapirovski to TSCC doc: add apapirovski to TSC Sep 5, 2018
@Trott Trott force-pushed the add-anatoli-to-tsc branch from aa0216a to ab20151 Compare September 5, 2018 21:36
mcollina
mcollina approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Sep 5, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/807/

@apapirovski
Copy link
Member

I probably shouldn't approve this but yay! 🎉 🙏

Trott added a commit to Trott/io.js that referenced this pull request Sep 5, 2018
@Trott
doc: add apapirovski to TSC
04195ad 
PR-URL: nodejs#22717
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
Copy link
Member Author

Trott commented Sep 5, 2018

Landed in 04195ad

@Trott Trott closed this Sep 5, 2018
@apapirovski apapirovski mentioned this pull request Sep 5, 2018
Closed
targos pushed a commit that referenced this pull request Sep 6, 2018
@Trott @targos
doc: add apapirovski to TSC
47acb78 
PR-URL: #22717
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Sep 12, 2018
@targos targos mentioned this pull request Sep 18, 2018
Merged
@Trott Trott deleted the add-anatoli-to-tsc branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@ofrobots ofrobots ofrobots approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @apapirovski @mcollina @ofrobots @addaleax @TimothyGu @targos