Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-trace-events-dns #22674

Merged
merged 1 commit into from
Sep 3, 2018
Merged

test: fix test-trace-events-dns #22674

merged 1 commit into from
Sep 3, 2018

Commits on Sep 3, 2018

  1. test: fix test-trace-events-dns 

    Test is using `common.fileExists()` which has been removed. There is no
need to check that the file exists as the attempt to read the file in
the next line will fail if the file does not exist. Remove existence
check.

PR-URL: nodejs#22674
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
    @Trott @refack
    Trott authored and refack committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    120814b View commit details
    Browse the repository at this point in the history