Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: disable debug options when inspector is unavailable #22657

Closed

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 2, 2018

This fixes parallel/test-cli-node-print-help when Node.js is compiled without the inspector.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This fixes `parallel/test-cli-node-print-help` when Node.js
is compiled without the inspector.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 2, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 2, 2018

@nodejs/build I don’t understand why e.g. https://ci.nodejs.org/job/node-test-commit-linux-containered/6764/nodes=ubuntu1604_sharedlibs_withoutintl_x64/console is not marked as a failure?

@addaleax addaleax added inspector Issues and PRs related to the V8 inspector protocol cli Issues and PRs related to the Node.js command line interface. labels Sep 2, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 2, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16961/ (:heavy_check_mark:)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 2, 2018
@@ -1,5 +1,6 @@
'use strict';
require('../common');
const common = require('../common');
common.skipIfInspectorDisabled();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Instead of skipping the test, can we use it to guard just the arguments that require inspector? We should still be able to run this on --eval, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, yes. Done! :)

@refack refack added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 2, 2018
@refack
Copy link
Contributor

refack commented Sep 2, 2018

Please 👍 for fast tracking this regression fix.

@refack
Copy link
Contributor

refack commented Sep 2, 2018

CI with fixed configuration: https://ci.nodejs.org/job/node-test-commit-linux-containered/6807/

@addaleax
Copy link
Member Author

addaleax commented Sep 2, 2018

Landed in c100d40 – thanks for the reviews!

@addaleax addaleax closed this Sep 2, 2018
@addaleax addaleax deleted the no-debug-options-without-inspector branch September 2, 2018 23:42
addaleax added a commit that referenced this pull request Sep 2, 2018
This fixes `parallel/test-cli-node-print-help` when Node.js
is compiled without the inspector.

PR-URL: #22657
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
This fixes `parallel/test-cli-node-print-help` when Node.js
is compiled without the inspector.

PR-URL: #22657
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2018
This fixes `parallel/test-cli-node-print-help` when Node.js
is compiled without the inspector.

PR-URL: #22657
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface. fast-track PRs that do not need to wait for 48 hours to land. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants