Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update v8.md #22639

Closed
wants to merge 2 commits into from
Closed

Update v8.md #22639

wants to merge 2 commits into from

Conversation

lakamsani
Copy link
Contributor

@lakamsani lakamsani commented Aug 31, 2018 •
edited by tniessen
Loading

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 31, 2018
@vsemozhetbyt vsemozhetbyt added the v8 engine Issues and PRs related to the V8 dependency. label Aug 31, 2018
richardlau
richardlau requested changes Aug 31, 2018
View reviewed changes
doc/api/v8.md Outdated Show resolved Hide resolved
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/760/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 1, 2018
@ChALkeR
Copy link
Member

ChALkeR commented Sep 1, 2018 •
edited
Loading

The actual change LGTM, but I have a pair of questions:
Was this found manually or during a dead links check?
Are there any more dead links?

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 1, 2018
@lakamsani
Copy link
Contributor Author

@ChALkeR I found this manually.

@vsemozhetbyt
Copy link
Contributor

Landed in 4bde70d
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Sep 3, 2018
@lakamsani @vsemozhetbyt
doc: update a link in v8.md
4bde70d 
PR-URL: #22639
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
@lakamsani @targos
doc: update a link in v8.md
56e654a 
PR-URL: #22639
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@lakamsani @targos
doc: update a link in v8.md
e761c40 
PR-URL: #22639
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lakamsani @vsemozhetbyt @ChALkeR @lpinca @richardlau @BridgeAR @nodejs-github-bot