Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add missing NODE_WANT_INTERNALS guards #22514

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

We generally add these to all headers that are considered
internal to Node.

These aren’t distributed as part of the headers tarball,
so I think this does not have to be semver-major
(and we have been changing the APIs in these headers
freely anyway).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

We generally add these to all headers that are considered
internal to Node.

These aren’t distributed as part of the headers tarball,
so I think this does not have to be semver-major
(and we have been changing the APIs in these headers
freely anyway).
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. dont-land-on-v8.x labels Aug 24, 2018
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 24, 2018
@addaleax
Copy link
Member Author

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 28, 2018
@alexkozy
Copy link
Member

just wondering. Is it possible to add this macro to v8-inspector.h as well inside v8 folder or there is only one option to land something to V8 by itself and then backport it to Node 11?

@addaleax
Copy link
Member Author

@ak239 I think that would be a question for @nodejs/v8-update … we don’t usually modify V8’s source files if we can avoid it, though.

Would it help if we removed v8-inspector{,-protocol}.h from the headers tarball that we publish alongside with Node?

@alexkozy
Copy link
Member

@addaleax,

Nice idea, it should help. As long as these headers are not available for native modules and we do not need to maintain ABI compatibility for them it will work. I will try to upload PR for this soon. Thanks!

@addaleax
Copy link
Member Author

Landed in 09fce85

@addaleax addaleax closed this Aug 28, 2018
@addaleax addaleax deleted the missing-wants-internals branch August 28, 2018 15:14
addaleax added a commit that referenced this pull request Aug 28, 2018
We generally add these to all headers that are considered
internal to Node.

These aren’t distributed as part of the headers tarball,
so I think this does not have to be semver-major
(and we have been changing the APIs in these headers
freely anyway).

PR-URL: #22514
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Aug 28, 2018
We generally add these to all headers that are considered
internal to Node.

These aren’t distributed as part of the headers tarball,
so I think this does not have to be semver-major
(and we have been changing the APIs in these headers
freely anyway).

PR-URL: #22514
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
We generally add these to all headers that are considered
internal to Node.

These aren’t distributed as part of the headers tarball,
so I think this does not have to be semver-major
(and we have been changing the APIs in these headers
freely anyway).

PR-URL: #22514
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2018
We generally add these to all headers that are considered
internal to Node.

These aren’t distributed as part of the headers tarball,
so I think this does not have to be semver-major
(and we have been changing the APIs in these headers
freely anyway).

PR-URL: #22514
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants