-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: export node_is_initialized #225
Conversation
I don't really want to export a global (before you ask: |
How about putting |
That seems reasonable to me. |
I have updated the patch. |
@piscisaureus LGTY? |
LGTM but a comment explaining why node_is_initialized is set where it's set makes it less likely to break in a future refactoring. |
This can make node_is_initialized correctly set to true for applications that use node::Init to embed iojs.
I have added some comments in the code to make things clear. |
This can make node_is_initialized correctly set to true for applications that use node::Init to embed iojs. PR-URL: #225 Reviewed-By: Ben Noordhuis <[email protected]>
Thanks Cheng, landed in 22e1aea. |
This gives users that using io.js as external library a chance to set
node_is_initialized
totrue
, otherwise it would impossible for them to use dynamic native modules.