Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 5.4.0 #22454

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 22, 2018

Update ESLint from 5.3.0 to 5.4.0. Note that the changeset is overwhelmingly deletions (+377, -5011) due to removing an unused dependency. \o/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Update ESLint from 5.3.0 to 5.4.0.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 22, 2018
@Trott
Copy link
Member Author

Trott commented Aug 22, 2018

Since this is an ESLint update, and the relevant code only gets exercised in the lint job, the pipeline job should be sufficient instead of a full CI.

Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@trivikr
Copy link
Member

trivikr commented Aug 22, 2018

cc @nodejs/linting

@jasnell
Copy link
Member

jasnell commented Aug 22, 2018

Rubber stamp LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 24, 2018
Update ESLint from 5.3.0 to 5.4.0.

PR-URL: nodejs#22454
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott
Copy link
Member Author

Trott commented Aug 24, 2018

Landed in adaaba0

@Trott Trott closed this Aug 24, 2018
targos pushed a commit that referenced this pull request Aug 24, 2018
Update ESLint from 5.3.0 to 5.4.0.

PR-URL: #22454
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
Update ESLint from 5.3.0 to 5.4.0.

PR-URL: #22454
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott Trott deleted the eslint-5.4.0 branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants