vm: move process.binding('contextify') to internalBinding #22419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
vm
nodejs-github-bot
added
the
lib / src
33 tasks
cjihrig
approved these changes
Aug 21, 2018
jasnell
added
the
author ready
|
Unrelated CI failures, resuming: https://ci.nodejs.org/job/node-test-pull-request/16636/ |
|
@nodejs/build ... complete CI failure on the arm cluster: https://ci.nodejs.org/job/node-test-binary-arm/2979/ |
|
Resuming again because of more unrelated CI failures: https://ci.nodejs.org/job/node-test-pull-request/16644/ |
BridgeAR
approved these changes
Aug 21, 2018
trivikr
approved these changes
Aug 22, 2018
arm cluster failure was due to a power outage at the "requireIO" HQ. it has been dealt with. |
refack
approved these changes
Aug 22, 2018
|
Resuming CI again: https://ci.nodejs.org/job/node-test-pull-request/16658/ |
|
CI is finally good! Need one more @nodejs/tsc sign off before I can land tho |
addaleax
approved these changes
Aug 23, 2018
jasnell
force-pushed
the
contextify-internal-binding
branch
from
2677164
to
ee130c1
Compare
jasnell
added a commit
that referenced
this pull request
Aug 23, 2018
PR-URL: #22419 Refs: #22160 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 4963a04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #22160
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes