os: destructure ERR_SYSTEM_ERROR properly

[cjihrig]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/590/pipeline

[targos]

Would there be any way to add a test for it?

[cjihrig]

Would there be any way to add a test for it?

'use strict';
// Monkey patch the os binding before requiring any other modules.
process.binding('os').getHomeDirectory = function(ctx) {
  ctx.syscall = 'foo';
  ctx.code = 'bar';
  ctx.message = 'baz';
};

const common = require('../common');
const os = require('os');

common.expectsError(os.homedir, {
  message: /^A system error occurred: foo returned bar \(baz\)$/
});

[BridgeAR]

@targos I guess it's your call if you want to have the test or not.

[targos]

I think it's good practice to land a regression test with the fix but I won't block this.

[cjihrig]

I've added a test coverage commit.

CI: https://ci.nodejs.org/job/node-test-pull-request/16608/

EDIT: CI was all green.

[targos]

Thanks!