-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: mark special entries as such #22287
Conversation
f766ef3
to
b361417
Compare
test/parallel/test-util-inspect.js
Outdated
`WeakSet { \u001b[${special[0]}m<items unknown>\u001b[${special[1]}m }` | ||
); | ||
assert.strictEqual( | ||
inspect(new WeakSet(), { colors: true }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this assertion repeated on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing author ready
label because of this open question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Copy paste error :) It's now resolved.
b62ab33
to
99b50c7
Compare
Rebased due to conflicts. |
This adds the color code to special entries if colors are active.
99b50c7
to
2988330
Compare
Rebased again due to conflicts. CI https://ci.nodejs.org/job/node-test-pull-request/16569/ ✔️ |
This adds the color code to special entries if colors are active. PR-URL: nodejs#22287 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in bd090f9 🎉 |
Should this be backported to |
Landed easily after #21869 |
This adds the color code to special entries if colors are active. PR-URL: #22287 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This adds the color code to special entries if colors are active. PR-URL: #22287 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This adds the color code to special entries if colors are active.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes