http2: explicitly disallow nested push streams #22245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v6.x
errors
jasnell
added
the
author ready
trivikr
approved these changes
Aug 11, 2018
jasnell
added a commit
that referenced
this pull request
Aug 13, 2018
Fixes: #19095 PR-URL: #22245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in 78584b6 |
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
Fixes: #19095 PR-URL: #22245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Aug 16, 2018
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 25, 2018
Fixes: nodejs#19095 PR-URL: nodejs#22245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
Fixes: nodejs#19095 PR-URL: nodejs#22245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2018
Fixes: #19095 Backport-PR-URL: #22850 PR-URL: #22245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19095
/cc @nodejs/http2
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes