Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add gdams to collaborators #22236

Closed
wants to merge 1 commit into from
Closed

doc: add gdams to collaborators #22236

wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Aug 10, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@gdams build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/491/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 10, 2018
addaleax
addaleax approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want a space after the email address :)

mhdawson
mhdawson approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome :)

@gdams
Copy link
Member Author

gdams commented Aug 10, 2018

New CI run after addressing changes: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/492/

@gdams gdams added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 10, 2018
@richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 10, 2018
@gdams
Copy link
Member Author

gdams commented Aug 10, 2018

landed as: 91e897a

@gdams gdams closed this Aug 10, 2018
gdams pushed a commit that referenced this pull request Aug 10, 2018
doc: add gdams to collaborators
91e897a 
PR-URL: #22236
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@richardlau richardlau mentioned this pull request Aug 10, 2018
Closed
@gdams gdams deleted the onboard branch August 10, 2018 17:17
targos pushed a commit that referenced this pull request Aug 11, 2018
@targos
doc: add gdams to collaborators
5ba56e5 
PR-URL: #22236
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gdams @nodejs-github-bot @refack @jasnell @Trott @addaleax @richardlau @mhdawson @vsemozhetbyt