Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: remove unused SSLWrap handle methods #22216

Closed
wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

One was not used at all, and the other was only used in a test, which I
converted to use the more standard ShutdownWrap API.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

One was not used at all, and the other was only used in a test, which I
converted to use the more standard `ShutdownWrap` API.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Aug 9, 2018
@maclover7
Copy link
Contributor Author

@Trott
Copy link
Member

Trott commented Aug 9, 2018

@nodejs/security-wg

(Unlikely to actually be a security issue, and security and crypto are not the same thing, and all that. But kind of trying to get a feel for PR volume if the "security and crypto changes need to go through Security WG" proposal goes through.)

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2018
@maclover7
Copy link
Contributor Author

Landed in 640dc7a

@maclover7 maclover7 closed this Aug 12, 2018
@maclover7 maclover7 deleted the jm-rm-tls-methods branch August 12, 2018 00:24
maclover7 added a commit that referenced this pull request Aug 12, 2018
One was not used at all, and the other was only used in a test, which I
converted to use the more standard `ShutdownWrap` API.

PR-URL: #22216
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Aug 12, 2018
One was not used at all, and the other was only used in a test, which I
converted to use the more standard `ShutdownWrap` API.

PR-URL: #22216
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants