Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util, assert: improve array comparison performance #22111

Closed
wants to merge 5 commits into from
Closed

util, assert: improve array comparison performance #22111

wants to merge 5 commits into from

Commits on Aug 3, 2018

  1. benchmark: improve assert benchmarks 

    This reduces the runtime and makes sure the strict and loose options
can be tested individually.

Besides that a couple of redundant cases were removed.
    @BridgeAR
    BridgeAR committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    c350d3e View commit details
    Browse the repository at this point in the history

  2. util,assert: improve performance 

    This adds a smarter logic to compare object keys and it also skips
the object key comparison for arrays, if possible.

Besides that it adds a fast path for empty objects and arrays.

It also adds a fast path for boxed strings and improves the
comparison performance for TypedArrays with extra keys on the object.

On top of that a few functions are now safer to call by using
uncurryThis and by caching the actual function.
    @BridgeAR
    BridgeAR committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    211b086 View commit details
    Browse the repository at this point in the history

  3. util,assert: fix boxed primitives bug 

    Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.
    @BridgeAR
    BridgeAR committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    98a4f90 View commit details
    Browse the repository at this point in the history

  4. test: improve test coverage for comparisons

    @BridgeAR
    BridgeAR committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    a93b55c View commit details
    Browse the repository at this point in the history

  5. fixup: benchmark commit

    @BridgeAR
    BridgeAR committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    778a2b1 View commit details
    Browse the repository at this point in the history