Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update recommendations for createCipher #22087

Closed
wants to merge 1 commit into from
Closed

doc: update recommendations for createCipher #22087

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Aug 2, 2018

Now that scrypt is supported, we should at least mention it as an alternative to PBKDF2.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. labels Aug 2, 2018
@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/402/pipeline

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Aug 2, 2018
@tniessen
Copy link
Member Author

tniessen commented Aug 2, 2018

cc @nodejs/crypto

@Trott
Copy link
Member

Trott commented Aug 2, 2018

@nodejs/security-wg

@lirantal
Copy link
Member

lirantal commented Aug 3, 2018

LGTM

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 4, 2018
tniessen added a commit to tniessen/node that referenced this pull request Aug 5, 2018
@tniessen
doc: update recommendations for createCipher
28c70ac 
PR-URL: nodejs#22087
Reviewed-By: Yihong Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@tniessen
Copy link
Member Author

tniessen commented Aug 5, 2018

Landed in 28c70ac.

@tniessen tniessen closed this Aug 5, 2018
targos pushed a commit that referenced this pull request Aug 6, 2018
@tniessen @targos
doc: update recommendations for createCipher
6c7733f 
PR-URL: #22087
Reviewed-By: Yihong Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@yhwang yhwang yhwang approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @Trott @lirantal @jasnell @yhwang @trivikr