Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: encode 0x27 (') for special URLs #22022

Closed
wants to merge 1 commit into from
Closed

src: encode 0x27 (') for special URLs #22022

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

Refs: whatwg/url@6ef17eb

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@TimothyGu build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/377/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jul 30, 2018
mscdex
mscdex reviewed Jul 30, 2018
View reviewed changes
test/fixtures/url-tests.js
@@ -2,7 +2,7 @@

/* The following tests are copied from WPT. Modifications to them should be
upstreamed first. Refs:
https://github.com/w3c/web-platform-tests/blob/88b75886e/url/urltestdata.json
https://github.com/web-platform-tests/wpt/blob/ba4921d054808a44c2966507c19861ca729a76a2/url/resources/urltestdata.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: perhaps we could make this URL at least a little shorter by reducing the length of the commit/tree hash?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@maclover7
Copy link
Contributor

Full CI: https://ci.nodejs.org/job/node-test-pull-request/16163/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2018
@jasnell
Copy link
Member

jasnell commented Aug 12, 2018

New CI (since the previous results are not accessible): https://ci.nodejs.org/job/node-test-pull-request/16382/

@jasnell
Copy link
Member

jasnell commented Aug 12, 2018

Running linux-containered CI again: https://ci.nodejs.org/job/node-test-commit-linux-containered/6196/

@jasnell
Copy link
Member

jasnell commented Aug 12, 2018

@nodejs/build ... linux-containered buildbot is having some issue here:

12:55:20 + git rebase --committer-date-is-author-date 01a160a05de56b8d8037250d28ce1ba4304a036c
12:55:20 Cannot rebase: You have unstaged changes.
12:55:20 Please commit or stash them.

@mmarchini
Copy link
Contributor

@nodejs/build ... linux-containered buildbot is having some issue here

On it. Seems to be some issue with EOL characters on deps/v8/third_party/jinja2/LICENSE.

@mmarchini
Copy link
Contributor

mmarchini commented Aug 12, 2018 •
edited by TimothyGu
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/16388/ ❌
CI: https://ci.nodejs.org/job/node-test-pull-request/16398/ ❌
CI: https://ci.nodejs.org/job/node-test-pull-request/16423/ ✅

@TimothyGu
Copy link
Member Author

Landed in c7788fb.

@TimothyGu TimothyGu closed this Aug 18, 2018
@TimothyGu TimothyGu deleted the url-updae branch August 18, 2018 19:18
TimothyGu added a commit that referenced this pull request Aug 18, 2018
@TimothyGu
src: encode 0x27 (') for special URLs
c7788fb 
Refs: whatwg/url@6ef17eb
PR-URL: #22022
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Aug 19, 2018
@TimothyGu @targos
src: encode 0x27 (') for special URLs
fb25130 
Refs: whatwg/url@6ef17eb
PR-URL: #22022
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
@TimothyGu @targos
src: encode 0x27 (') for special URLs
c207865 
Refs: whatwg/url@6ef17eb
PR-URL: #22022
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Sep 5, 2018
Merged
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@TimothyGu @nodejs-github-bot @maclover7 @jasnell @mmarchini @mscdex @lpinca @targos @cjihrig @BridgeAR