Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: rename vm.Module to vm.SourceTextModule #22007

Merged
merged 1 commit into from
Jul 31, 2018

Commits on Jul 31, 2018

  1. vm: rename vm.Module to vm.SourceTextModule

    At the last TC39 meeting, a new type of Module Records backed by
    JavaScript source called Dynamic Module Records was discussed, and
    it is now at Stage 1. Regardless of whether that proposal makes it
    all the way into the spec, SourceTextModule is indeed a more
    descriptive and accurate name for what this class represents.
    
    PR-URL: nodejs#22007
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Yuta Hiroto <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: John-David Dalton <[email protected]>
    Reviewed-By: Bradley Farias <[email protected]>
    devsnek committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    2bdcdfc View commit details
    Browse the repository at this point in the history