Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: convert addon-verify to remark #21978

Closed
wants to merge 4 commits into from
Closed

tools: convert addon-verify to remark #21978

wants to merge 4 commits into from

Conversation

rubys
Copy link
Member

@rubys rubys commented Jul 25, 2018

This is the last use of the remark module. tools/remark-cli and
tools/remark-preset-lint-node remain.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@rubys
tools: convert addon-verify to remark
9c66e71 
This is the last use of the remark *module*.  tools/remark-cli and
tools/remark-preset-lint-node remain.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jul 25, 2018
addaleax
addaleax approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only suggestion I’d have is that it might be nice to add a comment to the script that explains what it does. :)

richardlau
richardlau reviewed Jul 26, 2018
View reviewed changes
tools/doc/addon-verify.js Outdated
@@ -1,6 +1,11 @@
'use strict';

const { mkdir, readFileSync, writeFile } = require('fs');
// doc/api/addons.md has a bunch of code. Extract it for verification
// that the c++ code comples and the js code runs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiles

vsemozhetbyt
vsemozhetbyt reviewed Jul 26, 2018
View reviewed changes
tools/doc/addon-verify.js Outdated
@@ -1,28 +1,38 @@
'use strict';

const { mkdir, readFileSync, writeFile } = require('fs');
// doc/api/addons.md has a bunch of code. Extract it for verification
// that the c++ code complles and the js code runs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complles -> compiles :)
And maybe c++ -> C++

sagirk
sagirk approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@sagirk sagirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vsemozhetbyt

This comment has been minimized.

Sign in to view
@vsemozhetbyt
Copy link
Contributor

Another CI: https://ci.nodejs.org/job/node-test-pull-request/16031/

@vsemozhetbyt
Copy link
Contributor

Rebuild one failed OSX job: https://ci.nodejs.org/job/node-test-commit-osx/20042/

@vsemozhetbyt
Copy link
Contributor

Can anybody look into the failing OSX job? Is this related to the PR?

@Trott
Copy link
Member

Trott commented Jul 27, 2018

Can anybody look into the failing OSX job? Is this related to the PR?

No, it's a problem related to one or more of:

  • Recently moving to a new macOS provider in CI and the machines are a bit thinner on resources than they used to be, so builds are failing more often.
  • Recently changing addons to build in parallel rather than in series. It's possible all these failures in building addons are revealing a race condition there that isn't showing up elsewhere.

Those bullet points above are actually me just paraphrasing what others have told me, not anything I have much knowledge of, so.... @rvagg @refack @addaleax

@Trott
Copy link
Member

Trott commented Jul 27, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/16036/

@addaleax
Copy link
Member

@Trott Yes, it’s odd – it looks like it starts building addons before out/Release/node is created … that shouldn’t happen, as I understand the Makefile? @nodejs/build-files

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 27, 2018
@refack
Copy link
Contributor

refack commented Jul 27, 2018

#22006 tracking issue for this flakiness.

@vsemozhetbyt
Copy link
Contributor

Landed in 3ffd689
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Jul 28, 2018
@rubys @vsemozhetbyt
tools: convert addon-verify to remark
3ffd689 
This is the last use of the remark *module*. tools/remark-cli and
tools/remark-preset-lint-node remain.

PR-URL: #21978
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 31, 2018
@targos
Copy link
Member

targos commented Jul 31, 2018

Depends on #21697 to land on v10.x-staging

targos pushed a commit that referenced this pull request Aug 7, 2018
@rubys @targos
tools: convert addon-verify to remark
44edfa4 
This is the last use of the remark *module*. tools/remark-cli and
tools/remark-preset-lint-node remain.

PR-URL: #21978
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@richardlau richardlau richardlau left review comments

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@sagirk sagirk sagirk approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.