Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add HandleWrap::AddWrapMethods #21769

Closed
wants to merge 2 commits into from
Closed

src: add HandleWrap::AddWrapMethods #21769

wants to merge 2 commits into from

Conversation

maclover7
Copy link
Contributor

Extracts common setters to a single location

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@maclover7
src: add HandleWrap::AddWrapMethods
24fa76f 
Extracts common setters to a single location
@nodejs-github-bot
Copy link
Collaborator

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/253/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 11, 2018
addaleax
addaleax approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just fyi, I’d love to eventually move to using real function template inheritance for this :)

@maclover7
Copy link
Contributor Author

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15812/

jasnell
jasnell reviewed Jul 11, 2018
View reviewed changes
src/handle_wrap.cc Outdated
@@ -130,4 +131,13 @@ void HandleWrap::OnClose(uv_handle_t* handle) {
}


void HandleWrap::AddWrapMethods(Environment* env,
Local<FunctionTemplate> t) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indent alignment is slightly off on this line

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2018
@maclover7
Copy link
Contributor Author

CI before landing: https://ci.nodejs.org/job/node-test-pull-request/15848/

@maclover7
Copy link
Contributor Author

Landed in 45732c7

@maclover7 maclover7 closed this Jul 13, 2018
@maclover7 maclover7 deleted the jm-handle-common branch July 13, 2018 16:22
maclover7 added a commit that referenced this pull request Jul 13, 2018
@maclover7
src: add HandleWrap::AddWrapMethods
45732c7 
Extracts common setters to a single location

PR-URL: #21769
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 14, 2018
@targos
Copy link
Member

targos commented Jul 14, 2018

Should land cleanly on v10.x-staging after #21458

targos pushed a commit that referenced this pull request Jul 14, 2018
@maclover7 @targos
src: add HandleWrap::AddWrapMethods
4ed5d1a 
Extracts common setters to a single location

PR-URL: #21769
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 18, 2021
Open
This was referenced Jun 18, 2021
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@JungMinu JungMinu JungMinu approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maclover7 @nodejs-github-bot @targos @jasnell @addaleax @joyeecheung @JungMinu @BridgeAR