Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make Environment::is_stopping_worker inline #21720

Closed
wants to merge 1 commit into from
Closed

src: make Environment::is_stopping_worker inline #21720

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

Fixes a TODO comment

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@maclover7 maclover7 requested a review from addaleax July 9, 2018 15:11
@nodejs-github-bot
Copy link
Collaborator

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/229/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 9, 2018
addaleax
addaleax approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

@maclover7
Copy link
Contributor Author

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15775/

@maclover7 maclover7 self-assigned this Jul 11, 2018
@maclover7
Copy link
Contributor Author

Landing...

@maclover7
Copy link
Contributor Author

Landed in fcfd3e1

@maclover7 maclover7 closed this Jul 11, 2018
@maclover7 maclover7 deleted the jm-worker-inl branch July 11, 2018 13:53
maclover7 added a commit that referenced this pull request Jul 11, 2018
@maclover7
src: make Environment::is_stopping_worker inline
fcfd3e1 
Fixes a TODO comment.

PR-URL: #21720
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2018
@maclover7 @targos
src: make Environment::is_stopping_worker inline
2770778 
Fixes a TODO comment.

PR-URL: #21720
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees

@maclover7 maclover7

Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maclover7 @nodejs-github-bot @jasnell @addaleax @TimothyGu