Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check type for Worker filename argument #21620

Closed
wants to merge 1 commit into from
Closed

test: check type for Worker filename argument #21620

wants to merge 1 commit into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Jul 2, 2018

Add test to check type for first argument of Worker to increase
coverage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test: check type for Worker filename argument
28e8d29 
Add test to check type for first argument of Worker to increase
coverage.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 2, 2018
@lpinca
Copy link
Member

lpinca commented Jul 2, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15702/

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 2, 2018
@trivikr
Copy link
Member

trivikr commented Jul 4, 2018

Landed in 0b2ad91

@trivikr trivikr closed this Jul 4, 2018
trivikr pushed a commit that referenced this pull request Jul 4, 2018
@trivikr
test: check type for Worker filename argument
0b2ad91 
Add test to check type for first argument of Worker to increase
coverage.

PR-URL: #21620
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
targos pushed a commit that referenced this pull request Jul 4, 2018
@targos
test: check type for Worker filename argument
fe9888a 
Add test to check type for first argument of Worker to increase
coverage.

PR-URL: #21620
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
@refack refack mentioned this pull request Oct 18, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@JungMinu JungMinu JungMinu approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shisama @lpinca @trivikr @benjamingr @TimothyGu @cjihrig @tniessen @JungMinu @nodejs-github-bot