Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: fix undefined HTTP2 and tls errors #21564

Closed

Conversation

thatshailesh
Copy link
Contributor

@thatshailesh thatshailesh commented Jun 27, 2018

Includes implementation of tls, HTTP2 error with documentation
Ref: #21440

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Includes implementation of tls, HTTP2 error with documentation
@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Jun 27, 2018
<a id="ERR_TLS_RENEGOTIATE"></a>
### ERR_TLS_RENEGOTIATE

An attempt was made to renegotiate TLS session failed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this wording a bit off? Maybe An attempt made to renegotiate... or even An attempt to renegotiate...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure, thats why I asked everyone here #21440 about the message

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An attempt to renegotiate the TLS session failed.

@vsemozhetbyt vsemozhetbyt added tls Issues and PRs related to the tls subsystem. http2 Issues or PRs related to the http2 subsystem. labels Jun 27, 2018
@vsemozhetbyt vsemozhetbyt mentioned this pull request Jun 28, 2018
3 tasks
@ChALkeR
Copy link
Member

ChALkeR commented Jun 29, 2018

/cc @jasnell @mcollina @mhdawson

@ChALkeR ChALkeR requested a review from jasnell June 29, 2018 19:06
@vsemozhetbyt
Copy link
Contributor

ping @nodejs/http2

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

@vsemozhetbyt @jasnell are you now ok for this to land?

@jasnell
Copy link
Member

jasnell commented Jul 10, 2018 via email

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jul 10, 2018

If @jasnell's wording will be added while landing, I am OK)

@mcollina
Copy link
Member

mcollina commented Jul 10, 2018

Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the wording from @jasnell

@vsemozhetbyt
Copy link
Contributor

Let's land this tomorrow with the wording from @jasnell if there are no amendments by that time.

vsemozhetbyt pushed a commit that referenced this pull request Jul 13, 2018
Includes implementation of tls, HTTP2 error with documentation.

PR-URL: #21564
Refs: #21440
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@vsemozhetbyt
Copy link
Contributor

Landed in 3950a3e
Thank you!

targos pushed a commit that referenced this pull request Jul 14, 2018
Includes implementation of tls, HTTP2 error with documentation.

PR-URL: #21564
Refs: #21440
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@targos targos mentioned this pull request Jul 17, 2018
kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
Includes implementation of tls, HTTP2 error with documentation.

PR-URL: nodejs#21564
Refs: nodejs#21440
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
Includes implementation of tls, HTTP2 error with documentation.

PR-URL: nodejs#21564
Refs: nodejs#21440
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
Includes implementation of tls, HTTP2 error with documentation.

PR-URL: nodejs#21564
Refs: nodejs#21440
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
Includes implementation of tls, HTTP2 error with documentation.

Backport-PR-URL: #22850
PR-URL: #21564
Refs: #21440
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. http2 Issues or PRs related to the http2 subsystem. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants