-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: fix fsPromises.lchmod errors on non-Mac #21435
fs: fix fsPromises.lchmod errors on non-Mac #21435
Conversation
I think CI failures are unrelated to this. |
Thanks to #21498 , we can use |
f66c492
to
5aef2d8
Compare
@ChALkeR @jasnell @cjihrig @BridgeAR @starkwang @trivikr @targos @apapirovski Now, we can use |
Still LGTM. Thanks for updating this. |
On non-macOS, fsPromises.lchmod throws AssertionError. Expected behavior is `Error [ERR_METHOD_NOT_IMPLEMENTED]`. `ERR_METHOD_NOT_IMPLEMENTED()` requires argument, but it wasn't set. Fixes `ERR_METHOD_NOT_IMPLEMENTED()` to `ERR_METHOD_NOT_IMPLEMENTED('lchmod()')`. PR-URL: nodejs#21435 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
5aef2d8
to
f54958e
Compare
Looks like no objections. Rebased, commit message updated to exclude mentions of lchown, preparing to land. |
Landed in f54958e, thanks all! 🎉 |
On non-macOS, fsPromises.lchmod throws AssertionError. Expected behavior is `Error [ERR_METHOD_NOT_IMPLEMENTED]`. `ERR_METHOD_NOT_IMPLEMENTED()` requires argument, but it wasn't set. Fixes `ERR_METHOD_NOT_IMPLEMENTED()` to `ERR_METHOD_NOT_IMPLEMENTED('lchmod()')`. PR-URL: #21435 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
On non-macOS, fsPromises.lchmod and lchown throws AssertionError.
Expected behavior is
Error [ERR_METHOD_NOT_IMPLEMENTED]
.ERR_METHOD_NOT_IMPLEMENTED()
requires argument, but it didn't set.Fixes
ERR_METHOD_NOT_IMPLEMENTED()
toERR_METHOD_NOT_IMPLEMENTED('lchmod')
or
ERR_METHOD_NOT_IMPLEMENTED('lchown')
.Fixes: #21421
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes- [ ] documentation is changed or added