http2: pass incoming set-cookie header as array #21360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @nodejs/http2 |
|
@maclover7 @nodejs/github-bot any idea why neither the CI nor labelling script in the bot was triggered for this one? It seems rather strange. |
|
@ryzokuken The bot is down now: nodejs/build#1353 |
|
@nodejs/http2 PTAL |
TimothyGu
approved these changes
Jun 19, 2018
apapirovski
approved these changes
Jun 19, 2018
|
@apapirovski ok, will try to move the test. I have chosen the easiest way to reproduce this 😁 |
jasnell
approved these changes
Jun 21, 2018
trivikr
approved these changes
Jun 22, 2018
apapirovski
approved these changes
Jun 25, 2018
| // Tests the internal utility function that is used to prepare headers | ||
| // to pass to the internal binding layer. | ||
| // Tests the internal utility functions that are used to prepare headers | ||
| // to pass to the internal binding layer and to build a header object |
There was a problem hiding this comment.
Could you add a dot at the end of this sentence, please?
There was a problem hiding this comment.
Sure, will do that soon. As #21296 landed I have to update doc for set-cookie also.
apapirovski
added
the
author ready
|
Weird failures last time. CI: https://ci.nodejs.org/job/node-test-pull-request/15606/ |
|
@apapirovski Looks like CI got confused because I did a git rebase. It tries to checkout commit Applies at least to some of the CI jobs. |
|
Was there a merge commit by any chance? Weird that this is happening. Could you maybe squash? |
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code.
|
No, it was a "normal" rebase. Rebased again and squashed. |
|
Is there anything I should add here? |
|
Landed in d4966a1 |
mcollina
pushed a commit
that referenced
this pull request
Jul 5, 2018
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: #21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 6, 2018
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: #21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
This was referenced Jul 18, 2018
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Aug 23, 2018
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: nodejs#21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 25, 2018
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: nodejs#21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: nodejs#21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2018
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. Backport-PR-URL: #22850 PR-URL: #21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incoming set-cookie headers should be passed to user as array like in http module - even for single occurrence.
Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRegarding doc: If this PR is accepted #21296 should be updated accordingly - or doc needs to be adapted in this PR if #21296 landed meanwhile.