Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: handle OpenSSL error queue in CipherBase #21288

Closed
wants to merge 3 commits into from
Closed

crypto: handle OpenSSL error queue in CipherBase #21288

wants to merge 3 commits into from

Commits on Jun 12, 2018

  1. crypto: handle OpenSSL error queue in CipherBase 

    This handles all errors produced by OpenSSL within the CipherBase
class. API functions clear the error queue on return, utility
functions such as InitAuthenticated() ensure that they do not add
any new errors to the queue. Previously ignored return values are
now being CHECK'd.

Fixes: nodejs#21281
Refs: nodejs#21287
    @tniessen
    tniessen committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    643bc49 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2018

  1. Don't clear all errors in return 

    Instead of clearing all errors, mark and pop only errors that were
added within the current scope.
    @tniessen
    tniessen committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    0a89f42 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2018

  1. Add error checking for EVP_CipherInit_ex

    @tniessen
    tniessen committed Jul 1, 2018
    Configuration menu
    Copy the full SHA
    2fda8de View commit details
    Browse the repository at this point in the history