tools: install gdbinit from v8 to $PREFIX/share #2123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was suggested in #2076 (comment) |
| @@ -149,6 +149,8 @@ def files(action): | |||
| # behave similarly for systemtap | |||
| action(['src/node.stp'], 'share/systemtap/tapset/') | |||
|
|
|||
| action(['deps/v8/tools/gdbinit'], 'share/tools/') | |||
There was a problem hiding this comment.
Isn't /usr/share/node or /usr/share/doc/node a more logical place?
ofrobots
force-pushed
the
install-gdbinit
branch
2 times, most recently
from
4b66274
to
6aac5d7
Compare
|
LGTM |
|
On second thought, I think this should also be added to the |
|
Done. I am not too familiar with rpm packaging, so PTAL. |
|
I try to keep them in alphabetical order but that's nitpicking. LGTM. |
gdbinit provided by V8 can be very useful for low-level debugging of crashes in node and in binary addons. Most useful commands at 'jst' for JS stack traces and 'job' for printing a heap object. This patch installs the file at $PREFIX/share/tools/gdbinit.
|
Fixed. |
ofrobots
added a commit
that referenced
this pull request
Jul 7, 2015
gdbinit provided by V8 can be very useful for low-level debugging of crashes in node and in binary addons. Most useful commands at 'jst' for JS stack traces and 'job' for printing a heap object. This patch installs the file at $PREFIX/share/doc/node/gdbinit. Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: #2123
|
Landed in ee3ce2e. |
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
gdbinit provided by V8 can be very useful for low-level debugging of crashes in node and in binary addons. Most useful commands at 'jst' for JS stack traces and 'job' for printing a heap object. This patch installs the file at $PREFIX/share/doc/node/gdbinit. Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: nodejs#2123
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gdbinit provided by V8 can be very useful for low-level debugging of crashes in node and in binary addons. Most useful commands at 'jst' for JS stack traces and 'job' for printing a heap object.
This patch installs the file at $PREFIX/share/tools/gdbinit making it available on installed Node.js binaries too.
Here's a sample session that uses these gdb macros: https://gist.github.com/ofrobots/0bdcab89771221ace68d