Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove string literals from assert.strictEqual() calls #21211

Closed
wants to merge 1 commit into from
Closed

test: remove string literals from assert.strictEqual() calls #21211

wants to merge 1 commit into from

Commits on Jun 8, 2018

  1. test: remove string literals from assert.strictEqual() calls 

    In test/parallel/test-intl.js, five calls to assert.strictEqual() use a
third, string-literal parameter, which specifies a message to display
when the assertion fails. The problem is that if the assertion fails,
the error message will show the string literal but not the values that
caused the assertion to fail.

This commit removes the third parameter from the five calls and makes
them comments above the assertions instead. The default error message
produced by assert.strictEqual() shows the values that caused the
assertion to fail, which should be somewhat more helpful.
    @kylstraj
    kylstraj committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    cedd813 View commit details
    Browse the repository at this point in the history