test: remove postmortem test from flaky list #21092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
post-mortem
targos
approved these changes
Jun 2, 2018
test-postmortem-metadata does not ever seem to fail on master. According to Michaël Zasso, when it fails locally for him during a V8 upgrade, he pings Colin Ihrig who fixes it almost immediately. There was some discussion about marking it flaky when it first landed but it's not clear to me that it is necessary. (We can always mark it flaky again if it turns out that it is necessary.) The reason I want this test removed from the status file for flaky tests is that I believe that file can and should be used as a list of tests to fix. But this test doesn't need any fixing. Refs: nodejs#17685
Trott
added
the
author ready
|
Linux CI stalled on one host. Re-running: https://ci.nodejs.org/job/node-test-commit-linux/19269/ |
joyeecheung
approved these changes
Jun 2, 2018
richardlau
approved these changes
Jun 2, 2018
lpinca
approved these changes
Jun 2, 2018
trivikr
approved these changes
Jun 3, 2018
hashseed
approved these changes
Jun 4, 2018
|
As per @mmarchini’s comment, I think we don’t need this PR anymore, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-postmortem-metadata does not ever seem to fail on master. According
to Michaël Zasso, when it fails locally for him during a V8 upgrade, he
pings Colin Ihrig who fixes it almost immediately.
There was some discussion about marking it flaky when it first landed
but it's not clear to me that it is necessary. (We can always mark it
flaky again if it turns out that it is necessary.)
The reason I want this test removed from the status file for flaky tests
is that I believe that file can and should be used as a list of tests to
fix. But this test doesn't need any fixing.
Refs: #17685
@bnoordhuis @cjihrig @targos @nodejs/v8-update
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes