Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove empty-directory fixture #21044

Closed
wants to merge 3 commits into from
Closed

remove empty-directory fixture #21044

wants to merge 3 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 30, 2018

Instead of having an empty directory fixture (that isn't actually empty because git can't track an empty directory), use tmpdir.path after running tmpdir.refresh().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Trott added 3 commits May 30, 2018 15:15
@Trott
test: avoid empty fixture in fs test
ffa668a 
Refactor test-fs-error-messages to use tmpdir for its empty directory
rather than using a not-actually-empty directory called "empty" in
fixtures.
@Trott
test: avoid empty fixture in module test
079f431 
Refactor test-module-loading to use tmpdir for its empty directory
rather than using a not-actually-empty directory called "empty" in
fixtures.
@Trott
test: remove unused empty fixture
7f736d5 
The not-quite-empty directory called "empty" in fixtures was replaced in
tests with `tmpdir.path` (after calling `tmpdir.refresh()` to ensure
that it is empty). The fixture is removed in this commit.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 30, 2018
@Trott
Copy link
Member Author

Trott commented May 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15172/

@nodejs nodejs deleted a comment from refack Jun 1, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jun 1, 2018
@Trott
test: avoid empty fixture in fs test
de8ef3f 
Refactor test-fs-error-messages to use tmpdir for its empty directory
rather than using a not-actually-empty directory called "empty" in
fixtures.

PR-URL: nodejs#21044
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Jun 1, 2018
@Trott
test: avoid empty fixture in module test
c903a9e 
Refactor test-module-loading to use tmpdir for its empty directory
rather than using a not-actually-empty directory called "empty" in
fixtures.

PR-URL: nodejs#21044
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Jun 1, 2018
@Trott
test: remove unused empty fixture
69528b0 
The not-quite-empty directory called "empty" in fixtures was replaced in
tests with `tmpdir.path` (after calling `tmpdir.refresh()` to ensure
that it is empty). The fixture is removed in this commit.

PR-URL: nodejs#21044
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 1, 2018

Landed in 42dbb60...69528b0

@Trott Trott closed this Jun 1, 2018
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
@Trott @MylesBorins
test: avoid empty fixture in fs test
c74c83a 
Refactor test-fs-error-messages to use tmpdir for its empty directory
rather than using a not-actually-empty directory called "empty" in
fixtures.

PR-URL: #21044
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
@Trott @MylesBorins
test: avoid empty fixture in module test
f7886ab 
Refactor test-module-loading to use tmpdir for its empty directory
rather than using a not-actually-empty directory called "empty" in
fixtures.

PR-URL: #21044
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
@Trott @MylesBorins
test: remove unused empty fixture
60abd08 
The not-quite-empty directory called "empty" in fixtures was replaced in
tests with `tmpdir.path` (after calling `tmpdir.refresh()` to ensure
that it is empty). The fixture is removed in this commit.

PR-URL: #21044
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
Merged
@Trott Trott deleted the berlin-5 branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @apapirovski @jasnell @lpinca @richardlau @trivikr @nodejs-github-bot