doc: better font stack for monospace in docs #21036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appear to be rendering issues with inconsistent glyph width when using the Monaco font on non-macOS machines. This change updates the native CSS font stack to use the same font stack as Boostrap does, minus the Monaco font.
devsnek
approved these changes
May 30, 2018
Hmm, I'm a bit reluctant on that one because of its ligatures. Should we take it as consent that if a user has that font installed, they want ligatures? |
lpinca
approved these changes
May 30, 2018
trivikr
approved these changes
May 31, 2018
|
@nodejs/website |
|
@Trott LGTM! |
ckotzbauer
approved these changes
May 31, 2018
yorkie
approved these changes
May 31, 2018
WaleedAshraf
approved these changes
May 31, 2018
LinusU
approved these changes
May 31, 2018
daxlab
approved these changes
May 31, 2018
|
Landed in 0baad8f, might be something to backport later. |
silverwind
added a commit
that referenced
this pull request
May 31, 2018
There appear to be rendering issues with inconsistent glyph width when using the Monaco font on non-macOS machines. This change updates the native CSS font stack to use the same font stack as Boostrap does, minus the Monaco font. PR-URL: #21036 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yazhong Liu <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
fhemberger
added a commit
to nodejs/nodejs.org
that referenced
this pull request
May 31, 2018
fhemberger
added a commit
to nodejs/nodejs.org
that referenced
this pull request
May 31, 2018
addaleax
pushed a commit
that referenced
this pull request
Jun 1, 2018
There appear to be rendering issues with inconsistent glyph width when using the Monaco font on non-macOS machines. This change updates the native CSS font stack to use the same font stack as Boostrap does, minus the Monaco font. PR-URL: #21036 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yazhong Liu <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThere appear to be rendering issues with inconsistent glyph width when using the Monaco font on non-macOS machines. This change updates the native CSS font stack to use the same font stack as Boostrap does, minus the Monaco font.
Before:
After:
