Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: do not crash when using a closed fs event watcher #20985

Closed
wants to merge 1 commit into from

Commits on May 27, 2018

  1. fs: do not crash when using a closed fs event watcher

    Before this commit, when the user calls methods on a closed or
    errored fs event watcher, they could hit a crash since the
    FSEventWrap in C++ land may have already been destroyed with
    the internal pointer set to nullptr. This commit makes sure
    that the user cannot hit crashes like that, instead the
    methods calling on a closed watcher will be noops.
    
    Also explicitly documents that the watchers should not be used
    in `close` and `error` event handlers.
    joyeecheung committed May 27, 2018
    Configuration menu
    Copy the full SHA
    5f7e056 View commit details
    Browse the repository at this point in the history