Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix outdated link FSEvents #20949

Closed
wants to merge 1 commit into from
Closed

doc: fix outdated link FSEvents #20949

wants to merge 1 commit into from

Conversation

amitbend
Copy link
Contributor

@amitbend amitbend commented May 24, 2018 •
edited
Loading

Changed the link for FSEvents in the docs as suggested in issue #20853

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 24, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 24, 2018 •
edited
Loading

Fixes: #20853

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/752/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 25, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 25, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 8a58ec6
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request May 25, 2018
@amitbend @vsemozhetbyt
doc: fix outdated link FSEvents
8a58ec6 
PR-URL: #20949
Fixes: #20853
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request May 25, 2018
@amitbend @targos
doc: fix outdated link FSEvents
c036cda 
PR-URL: #20949
Fixes: #20853
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@amitbend @vsemozhetbyt @jasnell @lpinca @cjihrig @BridgeAR @trivikr @nodejs-github-bot