test: remove third argument(string literal) from strictEqual() #20920
Conversation
In test/parallel/test-stream-pip-await-drain-push-while-write.js, There are two calls in it to assert.strictEqual(). Both calls are provided with three arguments. The third argument in each case is a string literal. Unfortunately, that will suppress the presentation of the values of the first two arguments in the case of an AssertionError This is fixed by removing the third argument from the call. The third argument in the call is basically a string literal. Refs: https://www.nodetodo.org/getting-started
| @@ -7,17 +7,15 @@ const writable = new stream.Writable({ | |||
| write: common.mustCall(function(chunk, encoding, cb) { | |||
| assert.strictEqual( | |||
| readable._readableState.awaitDrain, | |||
| 0, | |||
| 'State variable awaitDrain is not correct.' | |||
There was a problem hiding this comment.
Would it be a good idea to preserve this message in a comment above the call to assert.strictEqual() — something like this // State variable awaitDrain should be 0?
cc: @Trott
There was a problem hiding this comment.
A static value is always bad. Someone will look at the line anyway, so the context will be clear.
There was a problem hiding this comment.
@sagirk I don't think it's needed in this case. A comment that says "awaitDrain should be 0" is superfluous above await.strictEqual(awaitDrain, 0).
|
@BridgeAR why these following errors are coming up? |
|
@AbhimanyuVashisht our test suite has flaky tests. Just ignore that. |
BridgeAR
added
author ready
Remove obsolete string literals from `assert.strictEqual()` calls in test/parallel/test-stream-pip-await-drain-push-while-write.js. PR-URL: nodejs#20920 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in 4970cd6 🎉 I fixed the commit message while landing to adhere to the 72 character rule as described in our guidelines and minimized the text somewhat. @AbhimanyuVashisht congratulations on your first commit to Node.js! 🎉 |
Remove obsolete string literals from `assert.strictEqual()` calls in test/parallel/test-stream-pip-await-drain-push-while-write.js. PR-URL: #20920 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
In
test/parallel/test-stream-pip-await-drain-push-while-write.js, There are twocalls in it to
assert.strictEqual(). Both calls are provided with threearguments. The third argument in each case is a string literal. Unfortunately,
that will suppress the presentation of the values of the first two arguments in
the case of an
AssertionErrorThis is fixed by removing the third argument from the call. The third argument
in the call is basically a string literal.
This particular issue is provided by @Trott, Thank you so much for getting me started.
Refs: https://www.nodetodo.org/getting-started
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes