Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove unnecessary string interpolation #20890

Closed
wants to merge 1 commit into from
Closed

lib: remove unnecessary string interpolation #20890

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 22, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label May 22, 2018
@danbev
Copy link
Contributor Author

danbev commented May 22, 2018

CI:https://ci.nodejs.org/job/node-test-pull-request/15020/

targos
targos approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the same can be done with "msg += ${warning.stack};" a few lines after?

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 22, 2018
@benjamingr
Copy link
Member

I guess the same can be done with "msg += ${warning.stack};" a few lines after?

Are we sure warning.stack warning.stack is a string?

@targos
Copy link
Member

targos commented May 23, 2018

@benjamingr

Are we sure warning.stack warning.stack is a string?

We're not, but I'm not aware of any difference between stringification from concatenation and using a template literal. It doesn't have to be changed in this PR though, there are enough LGTMs for the current changes.

@danbev
Copy link
Contributor Author

danbev commented May 24, 2018

Landed in 03043e2.

@danbev danbev closed this May 24, 2018
@danbev danbev deleted the lib_warning_unnecessary_string_interpolation branch May 24, 2018 08:20
danbev added a commit that referenced this pull request May 24, 2018
@danbev
lib: remove unnecessary string interpolation
03043e2 
PR-URL: #20890
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request May 25, 2018
@danbev @targos
lib: remove unnecessary string interpolation
d2bcd55 
PR-URL: #20890
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@JacksonTian JacksonTian JacksonTian approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.