trace_events: background thread metadata events #20823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
|
CI looks good – only failures are infrastructure or known issues. |
ofrobots
force-pushed
the
trace-buffer-earlier
branch
from
0a51327 to
db1154f
Compare
V8 uses a thread pool provided by the host to schedule background tasks for concurrent GC and compiation. Emit trace events to identify the background threads. Ensure that the tracing infrastructure is started before the thread pool is initialized. PR-URL: nodejs#20823 Reviewed-By: Matteo Collina <[email protected]>
ofrobots
force-pushed
the
trace-buffer-earlier
branch
from
db1154f to
32873c5
Compare
|
Landed as 32873c5. |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
V8 uses a thread pool provided by the host to schedule background tasks for concurrent GC and compiation. Emit trace events to identify the background threads. Ensure that the tracing infrastructure is started before the thread pool is initialized. PR-URL: #20823 Reviewed-By: Matteo Collina <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
V8 uses a thread pool provided by the host to schedule background tasks for concurrent GC and compiation. Emit trace events to identify the background threads. Ensure that the tracing infrastructure is started before the thread pool is initialized. PR-URL: #20823 Reviewed-By: Matteo Collina <[email protected]>
blattersturm
pushed a commit
to citizenfx/node
that referenced
this pull request
Nov 3, 2018
V8 uses a thread pool provided by the host to schedule background tasks for concurrent GC and compiation. Emit trace events to identify the background threads. Ensure that the tracing infrastructure is started before the thread pool is initialized. PR-URL: nodejs#20823 Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 uses a thread pool provided by the host to schedule background tasks
for concurrent GC and compiation. Emit trace events to identify the
background threads. Ensure that the tracing infrastructure is started
before the thread pool is initialized.
/cc @nodejs/trace-events @nodejs/diagnostics
EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/15001/