module: named anonymous function for debugging purposes

[ndangles]

My first contribution

This commit is to help in the effort to name all anonymous
functions to help when heap debugging. The issue asked for
any functions to be updated that are not on a prototype
and this file contains one function that meets those needs.

A previous pull request (13849) was not completed and did
not meet the requirements of the issue so this PR looks
to complete that.

Refs: #8913

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[tniessen]

Thank you for your contribution, Nicholas! 😃 Please note that the commit metadata does not match your GitHub account, so unless you either change your Git configuration or add the commit email address to your GitHub account, the commit will not be associated with your account when landed. Additionally, please double-check whether your PR actually Fixes: #8913. Fixes means that the issue as a whole will be closed when landing this PR, which might not be desired if you are only addressing parts of the issue. Use Refs for partial fixes.

[ndangles]

@tniessen Hello! I think I resolved the email issue.

The following commands were ran:
git rebase -i bb7912f
git commit --amend --author="ndangles [email protected]"
git rebase --continue
git push origin my-branch

[benjamingr]

Whoever is landing it on our end could just land just this one bb7912f and not the accidental commits from the pull/merge I think.

Is th email you're using associated with your GitHub account? https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/

[benjamingr]

Also, thanks for making a contribution, we genuinely appreciate it :]

[ndangles]

@benjamingr Yes, the email is associated with my Github account. Also, How I can I prevent accidental commits in the future? My intent was just to update the email metadata and not commit additional files.

Thank you!

[benjamingr]

@ndangles well, generally never add merge commits and if there is a conflict resolve it by rebasing the new work on top of what was already merged.

We have a pretty detailed guide at Pull Requests - you can also check out how we end up landing your code.

Honestly at the first few commits can be challenging. We don't blame people for not getting it 100% right and we just appreciate the effort and contribution.

It's pretty tricky to do initially and we understand that - don't worry about it :)

[ndangles]

@benjamingr This is my first time contributing to such a huge project so definitely a lot different then working on my own personal projects but I am willing to learn and hope to continue to contribute and I appreciate your help and patience

[tniessen]

@ndangles It seems like you added some more commits instead of updating the metadata of your own commit. We can fix that later, but feel free to follow these steps to update your commit with the correct metadata:

# Let's first remove the unwanted commits from your branch:
git checkout issue-8913
git reset --hard bb7912f577d667be2343070869fcece1f437cc13

# If you did not add the upstream remote yet, do so now:
git remote add upstream https://github.com/nodejs/node.git

# Rebasing is optional, but why not?
git fetch upstream master
git rebase upstream/master

# Your commit should still be the most recent commit at this point, but let's check:
git log --oneline -1

# Let's fix the committer metadata:
# (Note that most people use their real name here instead of their GitHub handle, but feel
# free to use whatever you want.)
git config user.email "[email protected]"
git config user.name "Nicholas Dangles"
# Finally, we also need to fix the author metadata:
git commit --amend --author="Nicholas Dangles <[email protected]>"

# Check that the metadata is correct:
git show --format=fuller --quiet

# Update your PR:
git push origin issue-8913 --force-with-lease

If everything worked, this PR should then list a single commit which is associated with your account.

[ndangles]

@tniessen Okay awesome, looked like everything worked. Thank you very much, that was very informative and I understand more now.

[tniessen]

Commit message should be fixed while landing.

[ndangles]

@tniessen Are there any other things I need to do from my end?

[benjamingr]

@ndangles pull requests in Node.js stay open for 48-72 hours (72 in this case because this is a weekend) before they are typically merged in order to give collaborators a chance to comment on them.*

If all goes well in a few days this will be merged as your first (and hopefully not last :)) commit in Node.js.

^{* we do sometimes fast-track things but in this case I don't think that's a big deal}

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/15059/

[benjamingr]

I could have sworn I approved it already.

[tniessen]

Landed in 65dbc52.

[ndangles]

@tniessen @benjamingr I appreciate the guidance and help on my first contribution. Thank you!