Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing changes: entry for assert.throws #20723

Closed
wants to merge 1 commit into from
Closed

doc: add missing changes: entry for assert.throws #20723

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #20485

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels May 14, 2018
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2018
@addaleax
Copy link
Member Author

/cc @BridgeAR

Please 👍 to approve fast-tracking this.

CI: https://ci.nodejs.org/job/node-test-commit-lite/885/

ryzokuken
ryzokuken approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@addaleax
Copy link
Member Author

Landed in 50b334b

@addaleax addaleax closed this May 14, 2018
addaleax added a commit that referenced this pull request May 14, 2018
@addaleax
doc: add missing changes: entry for assert.throws
50b334b 
Refs: #20485

PR-URL: #20723
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@addaleax addaleax deleted the assert-throws-changes branch May 14, 2018 18:00
addaleax added a commit that referenced this pull request May 14, 2018
@addaleax
doc: add missing changes: entry for assert.throws
9ecc746 
Refs: #20485

PR-URL: #20723
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@addaleax @MylesBorins
doc: add missing changes: entry for assert.throws
fd14ec1 
Refs: #20485

PR-URL: #20723
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @BridgeAR @ryzokuken @nodejs-github-bot