Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: no need to initial er with false #20607

Closed
wants to merge 1 commit into from
Closed

stream: no need to initial er with false #20607

wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented May 8, 2018 •
edited
Loading

initial er with false is unnecessarily.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@JacksonTian
stream: no need to initial er with false
00e2a03 
initial `er` with false is unnecessarily.
@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label May 8, 2018
@starkwang
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/14730/

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 12, 2018
@cjihrig cjihrig mentioned this pull request May 13, 2018
Merged
2 tasks
@trivikr
Copy link
Member

trivikr commented May 13, 2018

Landed in 0e9ea35

@trivikr trivikr closed this May 13, 2018
trivikr pushed a commit that referenced this pull request May 13, 2018
@JacksonTian @trivikr
stream: no need to initial er with false
0e9ea35 
initial `er` with false is unnecessarily.

PR-URL: #20607
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@JacksonTian JacksonTian deleted the err branch May 14, 2018 02:51
addaleax pushed a commit that referenced this pull request May 14, 2018
@JacksonTian @addaleax
stream: no need to initial er with false
ebc1b77 
initial `er` with false is unnecessarily.

PR-URL: #20607
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@starkwang starkwang starkwang approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JacksonTian @starkwang @trivikr @jasnell @lpinca @cjihrig @nodejs-github-bot