Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: wrap connect in nextTick #2054

Merged
merged 1 commit into from
Jul 1, 2015
Merged

net: wrap connect in nextTick #2054

merged 1 commit into from
Jul 1, 2015
+3 −1

Commits on Jul 1, 2015

  1. net: wrap connect in nextTick 

    Fixes an edge case regression introduced in
1bef717.

With the lookup being skipped, an error could be emitted before an
error listener has been added.

An example of this was presented by changing the server’s IP address
and then immediately making a request to the old address.

Related: nodejs#1823
PR-URL: nodejs#2054
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-by: Trevor Norris <[email protected]>
    @evanlucas
    evanlucas committed Jul 1, 2015
    Configuration menu
    Copy the full SHA
    af249fa View commit details
    Browse the repository at this point in the history