Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: document commit msg exception for long URLs #20207

Closed
wants to merge 1 commit into from
Closed

meta: document commit msg exception for long URLs #20207

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Fixes: #17116
Refs: nodejs/core-validate-commit#24

@vsemozhetbyt vsemozhetbyt added meta Issues and PRs related to the general management of the project. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 22, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 22, 2018
@vsemozhetbyt
Copy link
Contributor Author

Please, add 👍 here to approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/571/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 22, 2018
vsemozhetbyt added a commit that referenced this pull request Apr 22, 2018
@vsemozhetbyt
meta: document commit msg exception for long URLs
2060787 
PR-URL: #20207
Fixes: #17116
Refs: nodejs/core-validate-commit#24
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 2060787

@vsemozhetbyt vsemozhetbyt deleted the doc-commit-msg-long-urls branch April 22, 2018 10:26
@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 22, 2018
Closed
jasnell pushed a commit that referenced this pull request Apr 23, 2018
@vsemozhetbyt @jasnell
meta: document commit msg exception for long URLs
d591a59 
PR-URL: #20207
Fixes: #17116
Refs: nodejs/core-validate-commit#24
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @lpinca @BridgeAR @trivikr @nodejs-github-bot