-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update required compiler level for AIX #20153
Conversation
Compilers were updated for 10.X as per discussion in: nodejs/build#925
should we change |
Any objections to fast tracking this, need to get it into 10.X. @nodejs/tsc |
@gireeshpunathil I'm not too worried about having Unix and AIX listed as they are but open to other suggestions. We do want to get this sorted and into 10.X though so we don't have a lot of time to bikeshed. |
I'm fine with this because it's semver-major so we want to get it in 10.0.0, but I would otherwise say we should have a libstdc++ requirement in the table alongside the glibc requirement. The supported toolchains is mostly talking about what you need to build node, not run it, so it's not obvious from this that it's actually required to run Node. However the proper place for that information is in nodejs.org anyway (see nodejs/nodejs.org#955) so that's a separate issue. |
Going to land as I have 2 TSC +1's and no objection to fast track. CI Run (lite since its doc only): https://ci.nodejs.org/job/node-test-pull-request-lite/553/ |
CI green landing. |
Landed as 9459656 |
Compilers were updated for 10.X as per discussion in: nodejs/build#925 PR-URL: #20153 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
I get it, there were time constraints, it's a doc text change, etc., but just so no one else gets the wrong idea: This is not how our fast-tracking process works. "no objections to fast-tracking" is not a sign of approval. Two Collaborator approvals to fast-tracking are required to fast-track a PR. [EDIT: This was landed about a half hour before a 10.0.0 deadline for commits to land, so again: I totally get it. It had to land.] Almost no one actually respects that rule [EDIT: including me from time to time, I'm sorry to say, although I've stopped, honest!], and we should consider changing it or else starting to energetically enforce it/point out violations. It's kind of ridiculous, and if one part of our procedures is routinely ignored, it encourages people to ignore other parts of our procedures. |
Compilers were updated for 10.X as per discussion in: nodejs/build#925 PR-URL: #20153 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Post-landing LGTM. |
Compilers were updated for 10.X as per
discussion in: nodejs/build#925
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes