-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move back test-http-dump-req-when-res-ends #19866
Conversation
Can you run that same command on our CI. I never remember the task. |
This is on Ubuntu 16.04: |
The previous stress test didn't use parallelism. If you don't specify -j and --repeat in the stress test parameters, it's like running it in sequential. Here's a stress test that runs the test with multiple tests running simultaneously: https://ci.nodejs.org/job/node-stress-single-test/1799/ |
Removing |
@Trott on what platform it fails? The above stress test passed. |
The ubuntu stress test was successful. Original reports for this test failing were on alpine and freebsd and not ubuntu. Running on freebsd: |
Stress tests are looking good. Which is contradictory to what I'm seeing locally... I wonder if I'm doing something wrong... Investigating.... |
OK, it definitely fails on OS X. I see that locally and here it is in CI: https://ci.nodejs.org/job/node-stress-single-test/1808/nodes=osx1010/console |
Failing, although less frequently, on freebsd11-x64 too: https://ci.nodejs.org/job/node-stress-single-test/1810/nodes=freebsd11-x64/console |
Ok, I guess that by the time |
Fix test-http-dump-req-when-res-ends and move it back to test/parallel/ Refs: nodejs#19823
c38808f
to
d6c4cbe
Compare
CI: https://ci.nodejs.org/job/node-test-pull-request/14126/ |
This version passes for me. Probably a good idea for @BridgeAR to review again since this now includes changes to the test and isn't simply a file move. @nodejs/testing @nodejs/http |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@BridgeAR can you please update or remove your approval? Thanks. |
Landed in 96e82be. |
Fix test-http-dump-req-when-res-ends and move it back to test/parallel/ PR-URL: #19866 Refs: #19823 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Fix test-http-dump-req-when-res-ends and move it back to test/parallel/ PR-URL: #19866 Refs: #19823 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
I added the do not land labels as this is based on a semver-major |
Move back test-http-dump-req-when-res-ends to test/parallel/
Refs: #19823
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes